fix(apollo-react): addNodePanel scrolling [MST-9993]#752
Merged
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
Dependency License Review
License distribution
Excluded packages
|
Contributor
uipath-utkarsh
left a comment
uipath-utkarsh
left a comment
There was a problem hiding this comment.
Code review
The scrolling fix and the viewport-aware size cap are well put together (nice touches: the design-ceiling clamp, the reset-on-close to avoid a stale frame, the kept-in-sync comments). Three things worth addressing before merge — see inline. None block the AddNodeManager happy path; they're about the shared FloatingCanvasPanel contract and edge cases.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Comments suppressed due to low confidence (1)
packages/apollo-react/src/canvas/components/FloatingCanvasPanel/FloatingCanvasPanel.tsx:209
- In the
useFixedPosition && anchorRectbranch, the floating element never receivesref={refs.setFloating}(and no reference element is wired either). That means the newsize()middleware inuseFloatingPositionwon’t run, soavailableHeightstaysnullandsizingStylewon’t actually cap height or set--floating-available-heightfor fixed-position panels.
const fixedContent = (
<div
className={cn('nodrag nopan nowheel', panelClassName)}
onPointerEnter={onMouseEnter}
onPointerLeave={onMouseLeave}
style={{
position: 'fixed',
...screenPosition,
...sizingStyle,
zIndex: 1100,
pointerEvents: 'auto',
}}
>
<PanelChrome
title={title}
header={header}
headerActions={headerActions}
onClose={onClose}
scrollKey={scrollKey}
scrollableContent={scrollableContent}
>
{children}
</PanelChrome>
</div>
uipath-utkarsh
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make addNodePanel scrollable.
Also blocked the outer scroll i.e. FloatingCanvasPanel scroll only for addnodePanel
before
Screen.Recording.2026-05-26.at.4.15.57.PM.mov
after
Screen.Recording.2026-05-26.at.4.08.35.PM.mov